Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operation: DNS Over HTTPS #489

Merged
merged 7 commits into from
Feb 8, 2019
Merged

Operation: DNS Over HTTPS #489

merged 7 commits into from
Feb 8, 2019

Conversation

h345983745
Copy link
Contributor

@h345983745 h345983745 commented Feb 7, 2019

Pull request to implement #433.

Takes a domain name as input, before performing a fetch request to the specified resolver. If only the answer data is needed, an option to just return a JSON array of values is implemented.

It is worth noting that I have put this is the "code" module as I noticed that jsonpath library is used by the jpath recipe. It is also used in this recipe to implement the feature of only returning answer data rather than the full JSON response. I'm new to the CyberChef codebase so please let me know if there is a better way of doing this!

EDIT: I have now removed the jsonpath import and moved to the "Default" module.

Example Outputs:

screenshot 2019-02-06 at 23 30 36

screenshot 2019-02-06 at 23 31 29

@CLAassistant
Copy link

CLAassistant commented Feb 7, 2019

CLA assistant check
All committers have signed the CLA.

@h345983745 h345983745 closed this Feb 7, 2019
@h345983745 h345983745 reopened this Feb 7, 2019
@n1474335 n1474335 merged commit 75a58f4 into gchq:master Feb 8, 2019
@n1474335
Copy link
Member

n1474335 commented Feb 8, 2019

Great work, thank you very much!

@h345983745 h345983745 deleted the dnsoverhttps branch May 19, 2019 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants